https://bugzilla.redhat.com/show_bug.cgi?id=1803276 --- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Adam Borowski from comment #3) > I'm not sure about the testsuite issue. Yes, it would be nice to execute the test suite. Also, I would move the test suite into -doc subpackage, because it is not essential for runtime. And the Requires declarations should not be required, these are autogenerated. The HISTORY.md should be marked as a `%doc`, altouhg it is in -doc subpackage. I don't think the -doc subpackage needs the `BR/R: rubygems`. And it should be noarch. The `mv %{buildroot}/%{gem_instdir}/bin/* %{buildroot}/%{_bindir}` is definitely wrong. There should be already binary in `%{buildroot}%{_bindir}`. You don't properly unpack/rebuild/install the gem, as specified in guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/#_building_gems All in all, I am not sure what is the source of this package, but I'd say that recent version of rubygem-gem2rpm would provide you better scaffold to polish. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
