[Bug 1796271] Review Request: ocaml-lablgtk3 - OCaml interface to gtk3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1796271



--- Comment #6 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Iñaki Ucar from comment #5)
> - The devel subpackage misses the %{?_isa} flag in "Requires: %{name} =
> %{version}-%{release}".

Good catch.  Added.

> - Why is the sourceview3 subpackage named without the gtk prefix?

Because I want the subpackage names to match the opam names.  If you look
inside the build directory, you will find these files:
- lablgtk3.opam
- lablgtk3-gtkspell3.opam
- lablgtk3-sourceview3.opam

Hence the subpackages are named gtkspell3 and sourceview3.  Yes, it seems
inconsistent, but that's what upstream chose.

> - The examples directory is cleaned up, but it's not installed. Not sure if
> this is intentional.

I started work on packaging the examples, decided I didn't really want to
package them after all, then forgot to remove that.  I have removed it now.

And now the package is failing to build in mock, with a segfault.  I'm not sure
what changed.  I got a clean build when I filed the original review request.  I
will have to track this down before I can make a new SRPM.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux