https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #9 from Jerry James <loganjerry@xxxxxxxxx> --- Here's a full review. There are still a few issues, mostly minor except for some bundled fonts. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ That's the same warning fedora-review generated last time. This time I actually went to the referenced URL and read it. I know I said I didn't care, but the policy is quite clear. The BuildRequires is required. The wording of the policy leaves no wiggle room, so far as I can see. - Please consider changing the Source0 URL to this, so that the tarball contains the package name: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz - Please add %{?_isa} to the Requires on the main package in the subpackages: Requires: %{name}%{?_isa} = %{version}-%{release}. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package - The -desktop subpackage should Requires: hicolor-icon-theme, which owns the directories the icons are installed into. - The -desktop subpackage should also Requires: shared-mime-info, which owns /usr/share/mime/packages. - The -server subpackage contains a file marked %config but not %config(noreplace). Please either add the noreplace, or add a comment stating why it is inappropriate. - The main package has bundled fonts in these directories: /usr/libexec/rstudio/resources/presentation/revealjs.bundled/fonts /usr/libexec/rstudio/www/fonts The Lato fonts are available in the lato-fonts package. The others do not seem to be available from Fedora. See https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ for how they should be handled. - One of the SHOULD items is "Patches link to upstream bugs/comments/lists or are otherwise justified." Please consider doing so. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Affero General Public License", "AGPL", "*No copyright* GNU General Public License (v2)", "*No copyright* AGPL", "zlib/libpng license", "BSD 3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised" License GNU Affero General Public License", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)", "Expat License", "ISC License", "Mozilla Public License (v1.1 or later) GNU General Public License (v2 or later)", "Mozilla Public License (v1.1) GNU General Public License (v2 or later) or GNU Lesser General Public License (v2.1 or later)", "BSD 2-clause "Simplified" License", "Mozilla Public License GNU Lesser General Public License (v2.1)", "Apache License". 9273 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /usr/share/icons/hicolor/32x32/mimetypes, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/24x24/mimetypes, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/256x256/mimetypes, /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/mimetypes, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/24x24, /usr/share/icons/hicolor/16x16/mimetypes, /usr/share/icons/hicolor/24x24/apps, /usr/share/mime, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/256x256, /usr/lib/systemd, /usr/share/mime/packages, /usr/share/icons/hicolor/16x16/apps [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/pam.d/rstudio [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in rstudio-server [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rstudio- desktop , rstudio-server [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rstudio-1.2.5033-6.fc33.x86_64.rpm rstudio-desktop-1.2.5033-6.fc33.x86_64.rpm rstudio-server-1.2.5033-6.fc33.x86_64.rpm rstudio-debuginfo-1.2.5033-6.fc33.x86_64.rpm rstudio-debugsource-1.2.5033-6.fc33.x86_64.rpm rstudio-1.2.5033-6.fc33.src.rpm rstudio.x86_64: W: name-repeated-in-summary C RStudio rstudio.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/bin/pandoc/pandoc /usr/bin/pandoc rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/bin/pandoc/pandoc-citeproc /usr/bin/pandoc-citeproc rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/resources/dictionaries /usr/share/myspell rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/resources/grid/datatables.bundled/js/jquery.js /usr/share/javascript/jquery/latest/jquery.js rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/resources/mathjax-26 /usr/share/javascript/mathjax rstudio.x86_64: W: devel-file-in-non-devel-package /usr/libexec/rstudio/resources/templates/rcpp.cpp rstudio-desktop.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace rstudio-desktop.x86_64: W: no-documentation rstudio-desktop.x86_64: W: dangling-symlink /usr/bin/rstudio /usr/libexec/rstudio/bin/rstudio rstudio-desktop.x86_64: W: no-manual-page-for-binary rstudio rstudio-desktop.x86_64: W: desktopfile-without-binary /usr/share/applications/rstudio.desktop rstudio rstudio-server.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace rstudio-server.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/rstudio rstudio-server.x86_64: W: no-documentation rstudio-server.x86_64: W: dangling-symlink /usr/bin/rserver /usr/libexec/rstudio/bin/rserver rstudio-server.x86_64: W: dangling-symlink /usr/bin/rserver-pam /usr/libexec/rstudio/bin/rserver-pam rstudio-server.x86_64: W: dangling-symlink /usr/bin/rstudio-server /usr/libexec/rstudio/bin/rstudio-server rstudio-server.x86_64: W: no-manual-page-for-binary rserver rstudio-server.x86_64: W: no-manual-page-for-binary rserver-pam rstudio-server.x86_64: W: no-manual-page-for-binary rstudio-server rstudio.src: W: name-repeated-in-summary C RStudio rstudio.src: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace 6 packages and 0 specfiles checked; 0 errors, 24 warnings. Rpmlint (debuginfo) ------------------- Checking: rstudio-debuginfo-1.2.5033-6.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- rstudio-desktop.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace rstudio-desktop.x86_64: W: no-documentation rstudio-desktop.x86_64: W: dangling-symlink /usr/bin/rstudio /usr/libexec/rstudio/bin/rstudio rstudio-desktop.x86_64: W: no-manual-page-for-binary rstudio rstudio-server.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace rstudio-server.x86_64: W: conffile-without-noreplace-flag /etc/pam.d/rstudio rstudio-server.x86_64: W: no-documentation rstudio-server.x86_64: W: dangling-symlink /usr/bin/rserver /usr/libexec/rstudio/bin/rserver rstudio-server.x86_64: W: dangling-symlink /usr/bin/rserver-pam /usr/libexec/rstudio/bin/rserver-pam rstudio-server.x86_64: W: dangling-symlink /usr/bin/rstudio-server /usr/libexec/rstudio/bin/rstudio-server rstudio-server.x86_64: W: no-manual-page-for-binary rserver rstudio-server.x86_64: W: no-manual-page-for-binary rserver-pam rstudio-server.x86_64: W: no-manual-page-for-binary rstudio-server rstudio.x86_64: W: name-repeated-in-summary C RStudio rstudio.x86_64: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/bin/pandoc/pandoc /usr/bin/pandoc rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/bin/pandoc/pandoc-citeproc /usr/bin/pandoc-citeproc rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/resources/dictionaries /usr/share/myspell rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/resources/grid/datatables.bundled/js/jquery.js /usr/share/javascript/jquery/latest/jquery.js rstudio.x86_64: W: dangling-symlink /usr/libexec/rstudio/resources/mathjax-26 /usr/share/javascript/mathjax rstudio.x86_64: W: devel-file-in-non-devel-package /usr/libexec/rstudio/resources/templates/rcpp.cpp 5 packages and 0 specfiles checked; 0 errors, 21 warnings. Source checksums ---------------- https://s3.amazonaws.com/rstudio-buildtools/gin-2.1.2.zip : CHECKSUM(SHA256) this package : b98e704164f54be596779696a3fcd11be5785c9907a99ec535ff6e9525ad5f9a CHECKSUM(SHA256) upstream package : b98e704164f54be596779696a3fcd11be5785c9907a99ec535ff6e9525ad5f9a https://s3.amazonaws.com/rstudio-buildtools/gwt-2.8.2.zip : CHECKSUM(SHA256) this package : 970701dacc55170088f5eb327137cb4a7581ebb4734188dfcc2fad9941745d1b CHECKSUM(SHA256) upstream package : 970701dacc55170088f5eb327137cb4a7581ebb4734188dfcc2fad9941745d1b https://github.com/rstudio/rstudio/archive/v1.2.5033.tar.gz : CHECKSUM(SHA256) this package : ff5115bda56ee0fdee0ae2eb014ce5379774aeb3714a257a52da5b91a95e4408 CHECKSUM(SHA256) upstream package : ff5115bda56ee0fdee0ae2eb014ce5379774aeb3714a257a52da5b91a95e4408 Requires -------- rstudio (rpmlib, GLIBC filtered): /usr/bin/bash hunspell js-jquery ld-linux-x86-64.so.2()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.13)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5PrintSupport.so.5()(64bit) libQt5PrintSupport.so.5(Qt_5)(64bit) libQt5Quick.so.5()(64bit) libQt5Quick.so.5(Qt_5)(64bit) libQt5Solutions_SingleApplication-2.6.so.1()(64bit) libQt5WebChannel.so.5()(64bit) libQt5WebChannel.so.5(Qt_5)(64bit) libQt5WebEngineCore.so.5()(64bit) libQt5WebEngineCore.so.5(Qt_5)(64bit) libQt5WebEngineWidgets.so.5()(64bit) libQt5WebEngineWidgets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libR.so()(64bit) libboost_date_time.so.1.69.0()(64bit) libboost_filesystem.so.1.69.0()(64bit) libboost_iostreams.so.1.69.0()(64bit) libboost_program_options.so.1.69.0()(64bit) libboost_regex.so.1.69.0()(64bit) libboost_thread.so.1.69.0()(64bit) libc.so.6()(64bit) libcrypto.so.1.1()(64bit) libcrypto.so.1.1(OPENSSL_1_1_0)(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libpthread.so.0()(64bit) libssl.so.1.1()(64bit) libssl.so.1.1(OPENSSL_1_1_0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libutil.so.1()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) libz.so.1()(64bit) mathjax pandoc pandoc-citeproc rtld(GNU_HASH) shadow-utils systemd rstudio-desktop (rpmlib, GLIBC filtered): rstudio rstudio-server (rpmlib, GLIBC filtered): /bin/sh config(rstudio-server) pam rstudio rstudio-debuginfo (rpmlib, GLIBC filtered): rstudio-debugsource (rpmlib, GLIBC filtered): Provides -------- rstudio: bundled(aopalliance) bundled(gin) bundled(guice) bundled(gwt) bundled(gwt-websockets) bundled(hunspell) bundled(js-bn) bundled(js-datatables) bundled(js-highlight) bundled(js-pdf) bundled(js-qunit) bundled(js-reveal) bundled(js-xterm) bundled(json-spirit) bundled(sundown) bundled(synctex) rstudio rstudio(x86-64) rstudio-desktop: application() application(rstudio.desktop) mimehandler(application/x-r-data) mimehandler(application/x-r-project) mimehandler(text/css) mimehandler(text/html) mimehandler(text/javascript) mimehandler(text/x-R) mimehandler(text/x-c++hdr) mimehandler(text/x-c++src) mimehandler(text/x-chdr) mimehandler(text/x-csrc) mimehandler(text/x-markdown) mimehandler(text/x-r) mimehandler(text/x-r-doc) mimehandler(text/x-r-history) mimehandler(text/x-r-html) mimehandler(text/x-r-markdown) mimehandler(text/x-r-presentation) mimehandler(text/x-r-profile) mimehandler(text/x-r-source) mimehandler(text/x-r-sweave) mimehandler(text/x-tex) rstudio-desktop rstudio-desktop(x86-64) rstudio-server: config(rstudio-server) rstudio-server rstudio-server(x86-64) rstudio-debuginfo: debuginfo(build-id) rstudio-debuginfo rstudio-debuginfo(x86-64) rstudio-debugsource: rstudio-debugsource rstudio-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1803528 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Python, R, PHP, Perl, fonts, SugarActivity, Haskell, Ocaml, Java, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
