https://bugzilla.redhat.com/show_bug.cgi?id=1797363 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1797364 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source addresses are usable. Ok. TODO: The Url points to one of the documentation files. Please change it to <https://metacpan.org/release/Text-Layout> so that it points to the top level of the CPAN distribution. Source file (SHA-256: 58f8ef35c2e75e2d428f988b35984e807131311628eba01367ee3ea10b349b6a) is original. Ok. Summary verified from lib/Text/Layout.pm. Ok. Description verified from README. Ok. TODO: I recommend you to remove the status of the backends from the description. The status will evolve and the description could become outdated. FIX: The license tag is wrong. lib/Text/Layout.pm declaes "Artistic 2.0", README declares "GPL+ or Artistic". Please mention both licenses in the tag as "(GPL+ or Artistic) and Artistic 2.0". TODO: Do not use macros for simple commands. I.e. write "perl" instead of "%{__perl}". The same applies to %{__make}, %{__rm}, %{__chmod}. FIX: Remove "%{__rm} -rf %{buildroot}" line from %install section. It has no effect because it's a default behavior. FIX: Remove "find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'" line from %install section. It has no effect because no supported ExtUtils::MakeMaker creates empty directories. FIX: Remove %clean section. It has no effect because it's a default behavior. FIX: Remove %defattr(-,root,root,-) line from %files section. It has no effect because it's a default behavior. TODO: Call Makefile.PL with "NO_PACKLIST=1 NO_PERLLOCAL=1" arguments and use %{make_build} in %build section and %{make_install} in %install section as recommended in <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker> and <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make>. Then you don't need "find %{buildroot} -type f -name .packlist -exec rm -f {} ';'" line in %install section. No XS code, noarch BuildArch is Ok. FIX: Build-require "make" for (perl-Text-Layout.spec:66). FIX: Constrain "perl(PDF::API2)" dependency with ">= 2.036" (META.json:44). FIX: Build-require "perl(strict)" (Makefile.PL:3). FIX: Build-require "perl(warnings)" (Makefile.PL:4). FIX: "perl(ExtUtils::MakeMaker)" dependency version is incorrect. There should be ">= 6.46" (Makefile.PL:21). FIX: Build-require "perl(Carp)" (lib/Text/Layout.pm:9). FIX: Build-require "perl(constant)" (lib/Text/Layout.pm:115). FIX: Build-require "perl(File::Basename) (lib/Text/Layout/FontConfig.pm:436). FIX: Build-require "perl(overload)" (lib/Text/Layout/FontDescriptor.pm:197). FIX: Build-require "perl(utf8)" (lib/Text/Layout.pm:5). FATAL: "perl(HarfBuzz::Shaper) >= 0.018" dependency is not available in Fedora 33. Please package that dependency first. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1797364 [Bug 1797364] Review Request: perl-harfBuzz-Shaper - Interface to harfbuzz library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
