Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: syncevolution -- SyncML client for evolution https://bugzilla.redhat.com/show_bug.cgi?id=330661 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-14 23:58 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but NOT for RPM. syncevolution.i386: W: incoherent-version-in-changelog 0.6-1 0.6-2.fc8 => Add correct version as 0.6-2.fc8 while importing package in CVS. + source files match upstream. ad208478fa8d3ef05f89295e8f71b0f8 syncevolution-0.6.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package syncevolution-0.6-2.fc8 -> Requires: /usr/bin/perl curl evolution libORBit-2.so.0 libbonobo-2.so.0 libbonobo-activation.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcppunit-1.12.so.0 libcurl.so.4 libdl.so.2 libebook-1.2.so.9 libecal-1.2.so.7 libedataserver-1.2.so.9 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libgconf-2.so.4 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnome-2.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libm.so.6 libpopt.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) librt.so.1 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libxml2.so.2 perl(encoding) perl(integer) perl(strict) rtld(GNU_HASH) + Not a GUI app. SHOULD: Check with upstream for "make check" step. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review