[Bug 1806017] Review Request: opae - a sdk for fpga hardware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1806017

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>Group:          Development/Libraries
>Vendor:         Intel Corporation
>...
>Group:      Development/Libraries
These are not used in Fedora.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

>Requires:       libuuid, json-c, python
>BuildRequires:  python-devel
>BuildRequires:  python-sphinx
Referring to python in an unversion fashion is a big no-no in Fedora spec
files. ;)
You should explicitly specify "python3" here.

>Source0:        https://github.com/OPAE/opae-sdk/releases/download/%{version}-%{release}/%{name}-%{version}-%{release}.tar.gz
Do not include %{release} in the source name, as that will cause the source
name to change every time you make any changes to the spec.

>%package devel
>Requires:   %{name}
This should be a versioned dependency: "%{name}%{?_isa} =
%{version}-%{release}".
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package

>%files
>%defattr(-,root,root,-)
Do not use this unless you really need to.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux