[Bug 1805880] Review Request: sil-awami-nastaliq-fonts - A Nastaliq-style Arabic script font family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1805880

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|pnemade@xxxxxxxxxx          |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
Checking: sil-awami-nastaliq-fonts-2.000-1.fc33.noarch.rpm
          sil-awami-nastaliq-fonts-2.000-1.fc33.src.rpm
sil-awami-nastaliq-fonts.noarch: W: no-version-in-last-changelog
sil-awami-nastaliq-fonts.src: W: no-version-in-last-changelog
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Source checksums
----------------
https://github.com/silnrsi/font-awami/releases/download/v2.000/AwamiNastaliq-2.000.tar.xz
:
  CHECKSUM(SHA256) this package     :
35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80
  CHECKSUM(SHA256) upstream package :
35d3abbdc4756ed73371aadb5907f8d38457da374c9ee380cef771b9141c4b80


Requires
--------
sil-awami-nastaliq-fonts (rpmlib, GLIBC filtered):
    config(sil-awami-nastaliq-fonts)
    fontpackages-filesystem



Provides
--------
sil-awami-nastaliq-fonts:
    config(sil-awami-nastaliq-fonts)
    font(awaminastaliq)
    metainfo()
    metainfo(org.fedoraproject.sil-awami-nastaliq-fonts.metainfo.xml)
    sil-awami-nastaliq-fonts



All other things like license, config, metainfo files looks good.


Issues:
1) Please fix rpmlint warning "no-version-in-last-changelog" before import.
(Seems missing release number in Changelog)

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux