[Bug 1805926] Review Request: sil-mondulkiri-extra-fonts - Extra Khmer script font families from the SIL Mondulkiri project

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1805926

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|pnemade@xxxxxxxxxx          |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:

Not going for full package review.

This package follows new fonts packaging guidelines.

Rpmlint
-------
sil-busra-bunong-fonts.noarch: W: spelling-error %description -l en_US coengs
-> coverings
sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US
xspace -> space, x space
sil-busra-diagnostic-fonts.noarch: W: spelling-error %description -l en_US
coengs -> coverings
sil-busra-dot-fonts.noarch: W: spelling-error %description -l en_US codepoint
-> code point, code-point, codependent
sil-busra-moe-fonts.noarch: W: spelling-error %description -l en_US coeng ->
conger
sil-mondulkiri-extra-fonts-all.noarch: W: spelling-error %description -l en_US
metapackage -> meta package, meta-package, prepackage
sil-mondulkiri-extra-fonts-all.noarch: W: no-documentation
sil-mondulkiri-extra-fonts-doc.noarch: W: summary-not-capitalized C
sil-mondulkiri-extra-fonts optional documentation files
sil-mondulkiri-extra-fonts-doc.noarch: E: description-line-too-long C This
package provides optional documentation files shipped with
sil-mondulkiri-extra-fonts.
sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coengs ->
coverings
sil-ratanakiri-fonts.noarch: W: spelling-error %description -l en_US coeng ->
conger
12 packages and 0 specfiles checked; 1 errors, 10 warnings.


Source checksums
----------------
https://scripts.sil.org/cms/scripts/render_download.php?format=file&media_id=Mondulkiri-5.300&filename=Mondulkiri-5.300.zip#/Mondulkiri-5.300.zip
:
  CHECKSUM(SHA256) this package     :
4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88
  CHECKSUM(SHA256) upstream package :
4ff38760e48f3185c515088d91bc9e6a17402cbb3be316c06681c231db580f88



All other things like license, config, metainfo files looks good.

Issues:
1) Fix Summary not capitalized and description not wrapped to 80 characters.
2) fedora-review failed to install generated packages in mock. But let's not
block this review here. Tested manually installing generated packages. Working
fine.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux