Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gimp-lqr-plugin - GIMP LiquidRescale Plug-In https://bugzilla.redhat.com/show_bug.cgi?id=314871 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxx 2007-10-14 22:21 EST ------- Hi Alexandru, As I am unable to sponsor you this is an informal (and incomplete) review but does hi-light some issues which need to be fixed. ?? - Meets Packaging Guidelines. ?? - Package named correctly NA - Patches named correctly OK - Spec file named correctly to match base OK - License is valid OK - Licence field matches package OK - Licence file installed if supplied OK - Spec file in American English ?? - Source matches upstream (md5) NO * Locales use %find_lang OK - %clean is present and correct OK - Package has correct buildroot. OK - Specfile Legible NO * Builds in Mock NA - %post/%postun calls ldconfig for sh libs OK - Owns directories it creates OK - No duplicate files NO * Has %defattr and has correct permissions NO * Macros used consistently OK - %doc does not affect runtime NA - Headers/static libs in -devel NA - .pc files in -devel NA - .so files in -devel NA - -devel requires base OK - Contains no .la libtool archive files OK - Does not own others files NA - .desktop files installed correctly NO * BuildRequires correct. ?? - Package is code or permissible content. OK - Package has rm -rf %{buildroot} at top of %install. $RPM_BUILD_ROOT used instead ?? - Package compiles and builds on at least one arch. ?? - rpmlint output. NA - documentation in -doc package ?? - final provides and requires are sane. OK - should have dist tag ?? - should package latest version Comments and Suggestions. Summary Field should not be in camel caps, in my opinion it would be better as "Liquid rescale plug-in for the GIMP" or something more descriptive like "Content-aware resizing plug-in for the GIMP" The description does not state what the plugin actually does. Please use the ${name} macrom in the Source0: URL: %defattr MUST be at top of %files section Group: would be better as Applications/Multimedia There is a typo in the URL field. Package fails to build in mock. Please see http://marcbradshaw.co.uk/packages/review/gimp-lqr-plugin/ for build logs Please see the Locale section of http://fedoraproject.org/wiki/Packaging/Guidelines -Marc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review