https://bugzilla.redhat.com/show_bug.cgi?id=1803945 Ralf Senderek <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@xxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from Ralf Senderek <fedora@xxxxxxxxxxx> --- Before I start the formal review I'd like to have a few changes made to the spec file. 1) As the source code has a COPYING file with the license text you must include this file in a %license section. 2) Remove the line BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root as $RPM_BUILD_ROOT is used to access the correct directory. 3) Please remove the %clean section 4) Please avoid * in the %files section, you can list the two binaries by name for clarity. The %defattr is not needed. Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
