[Bug 1805043] Review Request: maven-native - Compile c and c++ source under Maven

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1805043



--- Comment #2 from Nicolas De Amicis <deamicis@xxxxxxxxxx> ---
(In reply to jiri vanek from comment #1)
> Please fix download urls:
> https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0-
> alpha-8/maven-native-1.0-alpha-8-source-release.zip
> Also there is newer version:
> https://repo1.maven.org/maven2/org/codehaus/mojo/natives/maven-native/1.0-
> alpha-9/
> In addition, on github is much nwer version.
> https://github.com/mojohaus/maven-native/releases/tag/maven-native-1.0-alpha-
> 11
> 
> Please use https://github.com/mojohaus/maven-native/ as URL and  fully
> qualified url for sources. I would chose the maven repo for them  anyway.
> 
> Maybe split %build's 
>    %mvn_build -f -s -- -Dmojo.java.target=1.7
> -Dmaven.test.failure.ignore=true
> to %build ad %check?
> 
> 
> Fedora review failed for me after build:
> NoneType: None
> 02-20 11:21 root         DEBUG    is_installed: Tested maven-native, result:
> 1
> 02-20 11:21 root         DEBUG    is_installed: Tested maven-native-javadoc,
> result: 1
> 02-20 11:21 root         DEBUG    is_installed: Tested native-maven-plugin,
> result: 1
> 02-20 11:21 root         DEBUG    Exception down the road...
> Traceback (most recent call last):
>   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
> line 236, in run
>     self._do_run(outfile)
>   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
> line 226, in _do_run
>     self._do_report(outfile)
>   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
> line 99, in _do_report
>     self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
>   File "/usr/lib/python3.7/site-packages/FedoraReview/review_helper.py",
> line 117, in _run_checks
>     self.checks.run_checks(output=output, writedown=not Settings.no_report)
>   File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 382,
> in run_checks
>     run_check(name)
>   File "/usr/lib/python3.7/site-packages/FedoraReview/checks.py", line 357,
> in run_check
>     check.run()
>   File
> "/usr/lib/python3.7/site-packages/FedoraReview/plugins/generic_build.py",
> line 282, in run
>     output = Mock.install(rpms)
>   File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 496, in
> install
>     rpms = [p for p in set(packages) if is_not_installed(p)]
>   File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 496, in
> <listcomp>
>     rpms = [p for p in set(packages) if is_not_installed(p)]
>   File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 487, in
> is_not_installed
>     if self.is_installed(p):
>   File "/usr/lib/python3.7/site-packages/FedoraReview/mock.py", line 408, in
> is_installed
>     rc = call(cmd, shell=True)
>   File "/usr/lib64/python3.7/subprocess.py", line 341, in call
>     return p.wait(timeout=timeout)
>   File "/usr/lib64/python3.7/subprocess.py", line 1019, in wait
>     return self._wait(timeout=timeout)
>   File "/usr/lib64/python3.7/subprocess.py", line 1653, in _wait
>     (pid, sts) = self._try_wait(0)
>   File "/usr/lib64/python3.7/subprocess.py", line 1611, in _try_wait
>     (pid, sts) = os.waitpid(self.pid, wait_flags)
> KeyboardInterrupt
> 02-20 11:21 root         ERROR    Exception down the road... (logs in
> /home/jvanek/.cache/fedora-review.log)
> 02-20 11:21 root         DEBUG    Report completed:  95.832 seconds
> 
> 
> However manual install passed fine, and maual investigation of rpmslooked
> fine.
> 
> Please fix what is possible. If fedora-review will remainbroken, I will do
> it manually.

Please find here the new spec file and SRPM file:
Spec URL: https://deamn.fedorapeople.org/maven-native.spec
SRPM URL:
https://deamn.fedorapeople.org/maven-native-1.0-0.1.alpha.11.fc31.src.rpm

> to %build ad %check?
could you explain more?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux