https://bugzilla.redhat.com/show_bug.cgi?id=1803281 --- Comment #2 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> --- Thanks for the review! So, to answer: 1. no %build section → this is normal, the package is not transforming source files, only ventilating them on the filesystem. Do you want me to add an empty %build section? I prefer avoiding those, we’ve had cases when buggy debuginfo (or other) macros assumed %build presence meant something happened in build, and specs with empty build sections failed in koji. But, in the absence of such bugs empty build sections are generally harmless 2. description is too long → what would be the correct description length for you? It does not seem especially long to me (way shorter than the description of glibc or systemd, for example) 3. Changelog lacks versions But it does include versions (it was one of the approved changelog formats, back when FPC cared about such things, and rpmbuild & friends have no difficulty parsing it) 4. and includes emoji. It’s valid UTF-8 and I like to make use of the fonts I package for Fedora;). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_encoding I can remove it if you feel strongly about it -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
