https://bugzilla.redhat.com/show_bug.cgi?id=1802177 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Hi! A few hints for a first-time packager (with line numbers, so you can see that I mean directly). 0) Use "raw" links when hosting files on GitHub for a package review. The `fedora-review` tool will try to fetch the .spec and .src.rpm files from the URLs listed, and the URLs you entered will return GitHub's UI instead of the raw files. There's a "Raw" button on the right, which gives you the direct download link to for the files. 1) You don't need to define srcname if your setting it to the package name anyway, just use %{name} instead, it's defined by the "Name: foo" line. https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L2 2) There's a typo in the package summary. Also, it's good form to not repeat the package name in the Summary, but be more descriptive ("Tweak settings for the Pantheon DE", or something like that). https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L5 3) The .spec is missing a URL that points to the upstream project. Add one like this, just above the Source0 line: URL: https://correct.url.here/elementary-tweaks 4) The Source0 is an unqualified tarball that does not reference the package version. This will lead to problems. Does the project offer downloads for specific versions? If so, use those URLs instead (and use the %{version} macro), which will help make some things easier later (including automatic release monitoring by fedora infrastructure). https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L10 5) You don't need to add both switchboard-devel and pkgconfig(switchboard-2.0) as build dependencies. These resolve to the same package (switchboard-devel). Remove the switchboard-devel BuildRequires and leave the pkgconfig(switchboard-2.0) dependency. https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L10 https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L24 6) The "Provides: elementary-tweaks = %{version}-%{release}" is redundant and is automatically added by RPM. Remove the line. https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L31 7) This looks like a spare space at the beginning of second line of the description: https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L36 8) Adjust the autosetup argument once you have a version-qualified source tarball: https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L39 9) %clean has not been used in fedora for ages and must not be used in .spec files anymore. Remove the %clean section. https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L50 10) You can't just own %{_libdir} and %{_datadir} as a whole. List only the directories / files that are created by this package directly, and not common filesystem paths (there are some exceptions to this rule, but none should apply here). https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L57 11) At the bottom, add a %changelog section. It's missing right now. https://github.com/a-mere-peasant/elementary-tweaks-fedora/blob/d0f5ef5/Packages/tweaks/elementary-tweaks.spec#L58 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
