https://bugzilla.redhat.com/show_bug.cgi?id=1803528 --- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> --- These are the issues fedora-review found: - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text I think that last one is talking about these files: - src/gwt/lib/gin/2.1.2/LICENSE - src/cpp/session/resources/presentation/revealjs/LICENSE Also, while the dictionaries may have come from Chromium, they are ultimately derived from hunspell. We have many hunspell dictionaries in Fedora, and not just the English ones. For the source of the bundled dictionaries in this package, see hunspell-en, hunspell-en-GB, and hunspell-en-US. I'm not sure how this should be handled, but you must either unbundle these dictionaries or add "Provides: bundled(hunspell-en)", etc. to the spec file. Speaking of bundling, this package bundles other software that we already have in Fedora. This is what I have found so far: - js-jquery: src/cpp/session/resources/grid/datatables/js/jquery.js - rapidxml-devel: src/cpp/core/include/core/rapidxml - texlive-synctex: src/cpp/core/tex/synctex - zlib: src/cpp/core/zlib and src/cpp/core/include/core/zlib I think we're going to have to go through the source tree carefully to see what else is bundled in it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
