Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: docker - KDE and GNOME2 system tray replacement docking application https://bugzilla.redhat.com/show_bug.cgi?id=245560 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-10-14 09:21 EST ------- Well * SourceURL - I recommend to use %name and %version macro, like ------------------------------------------------------------- Source0: http://icculus.org/openbox/2/%{name}/%{name}-%{version}.tar.gz ------------------------------------------------------------- With this, you probably don't have to change SourceURL when new version is released. * License policy has changed. http://fedoraproject.org/wiki/Packaging/LicensingGuidelines http://fedoraproject.org/wiki/Licensing - In short, you must specify the version of GPL. For this package this is "GPL+" (i.e. any version of GPL) because no version is specified on source codes. * Change %changelog entry like -------------------------------------------------------------- * Sun Jun 03 2007 Andreas Bierfert <andreas.bierfert[AT]lowlatency.de> - 1.5-1 - initial version -------------------------------------------------------------- Other things are okay. -------------------------------------------------------------- This package (docker) is APPROVED by me -------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review