[Bug 1804307] Review Request: python3-jack-client - JACK Audio Connection Kit (JACK) Client for Python 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1804307

Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |michel@xxxxxxxxxxxxxxx
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?
                   |                            |needinfo?(erich@ericheickme
                   |                            |yer.com)



--- Comment #1 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
I can sponsor.

So far most things look fine, but the source package naming does not match the
guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

(the rationale is that the Python major version might change -- or your package
might get branched for EPEL where we might build against multiple Python
major/minor version combination -- so the Python version should not be
hardcoded in the source package name).

Could you rename to python-jack-client (without 3)?

If you start with `rpmdev-newspec -t python python-jack-client` you'll get a
boilerplate Python template with the right stubs in place to handle the source
and binary name mismatch, and just need to move over your existing code.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux