https://bugzilla.redhat.com/show_bug.cgi?id=1802803 --- Comment #9 from Omair Majid <omajid@xxxxxxxxxx> --- (In reply to Michael Cronenworth from comment #8) > As this is a compiler and not a 'runtime' package as the name implies I > don't have reservations any more. If it is safe to drop the .a and .h files > then go ahead, but I no longer think they block the review. I tested this out. It's not safe to remove them. The runtime fails to start if the files are missing. The `dotnet --info` at the end of the build fails: + /home/omajid/rpmbuild/BUILDROOT/dotnet3.1-3.1.101-2.fc31.x86_64/usr/lib64/dotnet/dotnet --info Error: An assembly specified in the application dependencies manifest (Microsoft.NETCore.App.deps.json) was not found: package: 'runtime.fedora.31-x64.Microsoft.NETCore.App', version: '3.1.1-servicing.19608.4' path: 'runtimes/fedora.31-x64/native/System.IO.Compression.Native.a' > One minor issue is that your patches don't provide comments or context for > their existance. I do see the git comments inside of them but a comment in > the spec is always nice. Could you include a comment around them? Sure! > This review will PASS. Thanks! Wow, that's a plesant surprise. Thanks for the insanely prompt review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
