https://bugzilla.redhat.com/show_bug.cgi?id=1796268 Sergio Monteiro Basto <sergio@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(sanjay.ankur@gmai | |l.com) --- Comment #4 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> --- - I don't think both BuildArch and ExclusiveArch are necessary. Please remove BuildArch? Buildarch is noarch is correct , and we don't wnat try to build where nodejs doesn't exist all other packages have the same [1] - using_tarballs_from_the_npm_registry don't have test.js source , the rest of hte source is the same , I think the rue is obsolete . [1] https://src.fedoraproject.org/rpms/nodejs-p-locate/blob/master/f/nodejs-p-locate.spec#_19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
