https://bugzilla.redhat.com/show_bug.cgi?id=1801352 Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@xxxxxxxxxxxxxxxx --- Comment #3 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- Some observations at a first glance (not a formal review), as already pointed out on IRC: 1. %global debug_package %{nil} is almost always an error and a guideline/policy violation. (They are officially called "Guidelines", but they are really policies.) I see some BuildRequires on compiled libraries, so I assume this is not pure Python, but has some C++ or C code. For that code, the debuginfo extraction MUST be used. 2. That Provides/Requires filtering: Is this package using bundled JACK libraries? If so, why? And the required Provides: bundled(jack-audio-connection-kit) is missing in that case. But ideally, you should build against the system jack-audio-connection-kit-devel instead. 3. %files hardcodes /usr/bin and /usr/share instead of using %{_bindir} and %{_datadir} as it should. 4. %files lists only files and not directories. As a result, the directories are unowned. Directories should be listed either as %dir /path/to/dir (lists only the directory) or as /path/to/dir/ (which automatically includes all the files and subdirectories in that directory so that you do not have to list every single file individually as you did). If you have multiple files in a directory (that you do not want to list as a directory because it is owned by another package), you can also use wildcards. Though those should be used with care, because they can mask some unexpectedly added or removed files in new upstream versions (and in particular, the packaging guidelines now state that you must not wildcard library soversions to avoid accidental soname bumps). There are probably more issues, but those are the ones that caught my eye. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
