https://bugzilla.redhat.com/show_bug.cgi?id=1802171 --- Comment #3 from Ernestas Kulik <ekulik@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: restraint-upstream.spec should be restraint.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in restraint See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/restraint/client/bootstrap, /usr/share/restraint/plugins, /usr/share/selinux/packages/restraint, /usr/share/restraint/client, /usr/share/restraint [!]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ x: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [!]: Uses parallel make %{?_smp_mflags} macro. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in restraint-client [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/ekulik/Development/pagure.io/FedoraReview/copr- build-1237268/review-restraint-upstream/srpm-unpacked/restraint- upstream.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: restraint-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.x86_64.rpm restraint-client-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.x86_64.rpm restraint-debuginfo-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.x86_64.rpm restraint-debugsource-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.x86_64.rpm restraint-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.src.rpm restraint.x86_64: W: spelling-error %description -l en_US xml -> XML, ml restraint.x86_64: E: description-line-too-long C restraint harness which can run standalone or with beaker. when provided a recipe xml it will execute restraint.x86_64: E: no-changelogname-tag restraint.x86_64: W: no-documentation restraint.x86_64: W: no-manual-page-for-binary check_beaker restraint.x86_64: W: no-manual-page-for-binary restraintd restraint.x86_64: W: no-manual-page-for-binary rstrnt-abort restraint.x86_64: W: no-manual-page-for-binary rstrnt-adjust-watchdog restraint.x86_64: W: no-manual-page-for-binary rstrnt-backup restraint.x86_64: W: no-manual-page-for-binary rstrnt-package restraint.x86_64: W: no-manual-page-for-binary rstrnt-prepare-reboot restraint.x86_64: W: no-manual-page-for-binary rstrnt-reboot restraint.x86_64: W: no-manual-page-for-binary rstrnt-report-log restraint.x86_64: W: no-manual-page-for-binary rstrnt-report-result restraint.x86_64: W: no-manual-page-for-binary rstrnt-restore restraint.x86_64: W: no-manual-page-for-binary rstrnt-sync restraint.x86_64: W: no-manual-page-for-binary rstrnt-sync-block restraint.x86_64: W: no-manual-page-for-binary rstrnt-sync-set restraint.x86_64: W: percent-in-%preun restraint.x86_64: W: percent-in-%postun restraint-client.x86_64: E: explicit-lib-dependency libxslt restraint-client.x86_64: W: summary-not-capitalized C used to run jobs outside of beaker restraint-client.x86_64: W: spelling-error %description -l en_US restAPI -> rest API, rest-API, restate restraint-client.x86_64: E: description-line-too-long C With the restraint client you can run jobs outside of beaker. This will provide the same restraint-client.x86_64: E: no-changelogname-tag restraint-client.x86_64: W: no-documentation restraint-client.x86_64: W: no-manual-page-for-binary restraint restraint-debuginfo.x86_64: E: no-changelogname-tag restraint-debugsource.x86_64: E: no-changelogname-tag restraint.src: W: spelling-error %description -l en_US xml -> XML, ml restraint.src: E: description-line-too-long C restraint harness which can run standalone or with beaker. when provided a recipe xml it will execute restraint.src: E: no-changelogname-tag restraint.src: E: invalid-spec-name restraint.src: W: invalid-url Source0: restraint-restraint.0.1.45.1.8.ga4f5a7c.tar.gz 5 packages and 0 specfiles checked; 10 errors, 24 warnings. Rpmlint (debuginfo) ------------------- Checking: restraint-client-debuginfo-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.x86_64.rpm restraint-debuginfo-restraint.0.1.45.1.8.ga4f5a7c-1.fc32.x86_64.rpm restraint-client-debuginfo.x86_64: E: no-changelogname-tag restraint-debuginfo.x86_64: E: no-changelogname-tag 2 packages and 0 specfiles checked; 2 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). restraint-client-debuginfo.x86_64: E: no-changelogname-tag restraint-client-debuginfo.x86_64: W: invalid-url URL: https://github.com/beaker-project/restraint <urlopen error [Errno -2] Name or service not known> restraint.x86_64: W: spelling-error %description -l en_US xml -> XML, ml restraint.x86_64: E: description-line-too-long C restraint harness which can run standalone or with beaker. when provided a recipe xml it will execute restraint.x86_64: E: no-changelogname-tag restraint.x86_64: W: invalid-url URL: https://github.com/beaker-project/restraint <urlopen error [Errno -2] Name or service not known> restraint.x86_64: W: no-documentation restraint.x86_64: W: no-manual-page-for-binary check_beaker restraint.x86_64: W: no-manual-page-for-binary restraintd restraint.x86_64: W: no-manual-page-for-binary rstrnt-abort restraint.x86_64: W: no-manual-page-for-binary rstrnt-adjust-watchdog restraint.x86_64: W: no-manual-page-for-binary rstrnt-backup restraint.x86_64: W: no-manual-page-for-binary rstrnt-package restraint.x86_64: W: no-manual-page-for-binary rstrnt-prepare-reboot restraint.x86_64: W: no-manual-page-for-binary rstrnt-reboot restraint.x86_64: W: no-manual-page-for-binary rstrnt-report-log restraint.x86_64: W: no-manual-page-for-binary rstrnt-report-result restraint.x86_64: W: no-manual-page-for-binary rstrnt-restore restraint.x86_64: W: no-manual-page-for-binary rstrnt-sync restraint.x86_64: W: no-manual-page-for-binary rstrnt-sync-block restraint.x86_64: W: no-manual-page-for-binary rstrnt-sync-set restraint.x86_64: W: percent-in-%preun restraint.x86_64: W: percent-in-%postun restraint-debugsource.x86_64: E: no-changelogname-tag restraint-debugsource.x86_64: W: invalid-url URL: https://github.com/beaker-project/restraint <urlopen error [Errno -2] Name or service not known> restraint-debuginfo.x86_64: E: no-changelogname-tag restraint-debuginfo.x86_64: W: invalid-url URL: https://github.com/beaker-project/restraint <urlopen error [Errno -2] Name or service not known> restraint-client.x86_64: E: explicit-lib-dependency libxslt restraint-client.x86_64: W: summary-not-capitalized C used to run jobs outside of beaker restraint-client.x86_64: W: spelling-error %description -l en_US restAPI -> rest API, rest-API, restate restraint-client.x86_64: E: description-line-too-long C With the restraint client you can run jobs outside of beaker. This will provide the same restraint-client.x86_64: E: no-changelogname-tag restraint-client.x86_64: W: invalid-url URL: https://github.com/beaker-project/restraint <urlopen error [Errno -2] Name or service not known> restraint-client.x86_64: W: no-documentation restraint-client.x86_64: W: no-manual-page-for-binary restraint 5 packages and 0 specfiles checked; 8 errors, 27 warnings. Requires -------- restraint (rpmlib, GLIBC filtered): /bin/sh /usr/bin/bash /usr/bin/sh libarchive.so.13()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjson-c.so.4()(64bit) libpthread.so.0()(64bit) libsoup-2.4.so.1()(64bit) libutil.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.9.1)(64bit) rtld(GNU_HASH) selinux-policy systemd restraint-client (rpmlib, GLIBC filtered): libarchive.so.13()(64bit) libc.so.6()(64bit) libcurl.so.4()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libjson-c.so.4()(64bit) libpthread.so.0()(64bit) libsoup-2.4.so.1()(64bit) libutil.so.1()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxml2.so.2(LIBXML2_2.9.1)(64bit) libxslt rtld(GNU_HASH) restraint-debuginfo (rpmlib, GLIBC filtered): restraint-debugsource (rpmlib, GLIBC filtered): Provides -------- restraint: restraint restraint(x86-64) restraint-client: restraint-client restraint-client(x86-64) restraint-debuginfo: debuginfo(build-id) restraint-debuginfo restraint-debuginfo(x86-64) restraint-debugsource: restraint-debugsource restraint-debugsource(x86-64) Generated by fedora-review 0.7.4 (9bbd161) last change: 2020-02-03 Command line :./try-fedora-review --copr-build 1237268 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Ocaml, fonts, R, Python, SugarActivity, Java, Perl, PHP, Ruby, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
