https://bugzilla.redhat.com/show_bug.cgi?id=1801422 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Dan! (In reply to dan.cermak from comment #1) > I have the following comments: > > - doc package can be installed without requiring the main package and the > license will then not get installed > - ocaml-findlib is not required to build this package > - the -devel subpackage contains .ml files, which shouldn't be included as > per the packaging guidelines I have addressed each of these issues. I could have sworn I had problems with dune in another package when ocaml-findlib was not installed, but you are right; that doesn't seem to be the case with this package. I'll have to go back and see if I can drop that BR from the other packages I have submitted recently. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-stdint/ocaml-stdint.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-stdint/ocaml-stdint-0.6.0-2.fc32.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
