https://bugzilla.redhat.com/show_bug.cgi?id=1800663 Mark Goodwin <mgoodwin@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(agerstmayr@redhat | |.com) | --- Comment #3 from Mark Goodwin <mgoodwin@xxxxxxxxxx> --- (In reply to Andreas Gerstmayr from comment #2) > Thanks for the review! > > Jep, I though I package the version which Grafana requires, not the latest > upstream version. The fedora-review and policy states : "Latest version is packaged.". (it's the 4th item in the ===== SHOULD items ===== of the review). If a package needs to make a breaking change, then it should bump it's package name (e.g. foo.v1 to foo.v2) and both packages more or less exist independently - users can specify which package they require by name. > I've updated the package now to the latest upstream version 1.1.0, new URLs: > Spec URL: > https://raw.githubusercontent.com/andreasgerstmayr/specs/master/reviews/ > golang-github-beevik-etree/golang-github-beevik-etree.spec > SRPM URL: > https://github.com/andreasgerstmayr/specs/raw/master/reviews/golang-github- > beevik-etree/golang-github-beevik-etree-1.1.0-1.fc31.src.rpm I built and tested grafana-6.6.1 with the new golang-github-beevik-etree-1.1.0-1 and all is good, so there dont seem to be any issues with grafana using the new 1.1.0-1 version. package approved! thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
