https://bugzilla.redhat.com/show_bug.cgi?id=1798797 --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Ankur! (In reply to Ankur Sinha (FranciscoD) from comment #2) > I have a few nitpicks where the spec doesn't match the example spec in the > guidelines (which doesn't look to up to date). Please do just check on them > before importing: > https://docs.fedoraproject.org/en-US/packaging-guidelines/OCaml/ > > - Should it be BR: ocaml-findlib-devel (even though it builds fine, so > probably > not)? No, we only need the commandline tool "ocamlfind" from the ocaml-findlib package. We do not need to link to the actual library, which is what ocaml-findlib-devel enables. > - Are the _use_internal_dependency_generator etc. bits mentioned in the > example > spec not needed? Good grief, those should have been removed a long time ago. No, those should not be used anymore. > - I can't find much information about the cmxs file, so I don't know if it > should be included or not. The cmxs files are the OCaml versions of a shared library. On architectures where OCaml is able to build them ("%ifarch %{ocaml_native_compiler}"), they should be included. > - The build.log file shows some warnings/errors related to debuginfo > generation. They may not be related to the package: Dan commented on this. Thank you, Ankur! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
