https://bugzilla.redhat.com/show_bug.cgi?id=1801464 --- Comment #4 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Thanks for the quick review, Jerry. (In reply to Jerry James from comment #3) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Package installs properly. > Note: Installation errors (see attachment) > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ > > The failure is because this package requires mediawiki version 1.33, but > version 1.33.1 is currently in Rawhide. Fixed. I got the Requires wrong. > > - Remove the first line of %install: "rm -rf $RPM_BUILD_ROOT". See the 3rd > bullet item here: > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Removed > > - Please ask upstream to add a license file (SHOULD) I'll do that. They don't include it in the source tree either, so I'll have to sign up for their gerrit instance and so on. > > - There have been 8 commits to the repository after the commit chosen for > this package (regarding the "latest version" question in the SHOULD > section) > Ah, no---the plugin is linked to the mediawiki version. Since rawhide has 1.33, I'm packaging the latest commit in the REL_1_33 branch here: https://github.com/wikimedia/mediawiki-extensions-LastModified/tree/REL1_33 I've noted that in the spec for clarity also. I've also added back the js files. I looked at the mediawiki package, and the extensions it ships do include these. Updated spec/srpm: Spec URL: https://ankursinha.fedorapeople.org/mediawiki-lastmodified/mediawiki-lastmodified.spec SRPM URL: https://ankursinha.fedorapeople.org/mediawiki-lastmodified/mediawiki-lastmodified-0-0.1.20200210gitbe28231ebcd539fc99775811e5dc6df9064cfa94.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
