https://bugzilla.redhat.com/show_bug.cgi?id=1801527 Mark Goodwin <mgoodwin@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |mgoodwin@xxxxxxxxxx Flags| |fedora-review? | |needinfo?(nathans@xxxxxxxxx | |m) --- Comment #1 from Mark Goodwin <mgoodwin@xxxxxxxxxx> --- Hi Nathan, installing the BuildRequires pulled in redis, but the redis server is disabled by default on a fresh install and so the ExampleNewClient test failed with ECONREFUSED, see below. So now I'm wondering if it'd be feasible to actually run the redis server during a build for tests like this? After enabling and starting the redis server on my rawhide VM, the %check phase of the build worked fine and the resulting package installed ok (and grafana-6.1.1 built with it as a BR correctly). --- FAIL: ExampleNewClient (0.00s) got: dial tcp [::1]:6379: connect: connection refused want: PONG <nil> --- FAIL: ExampleClient (0.00s) panic: dial tcp :6379: connect: connection refused [recovered] panic: dial tcp :6379: connect: connection refused goroutine 1 [running]: testing.(*InternalExample).processRunResult(0xc00026fd58, 0x0, 0x0, 0x3b766, 0x565544cf0480, 0xc00042f0e0, 0x0) /usr/lib/golang/src/testing/example.go:89 +0x641 testing.runExample.func2(0xbf88b4bdf903fa1c, 0xb5e0bc1cf, 0x5655451a72e0, 0xc0005160a8, 0xc000010018, 0xc0005992c0, 0xc00026fd58, 0xc00026fd88) /usr/lib/golang/src/testing/run_example.go:58 +0x107 panic(0x565544cf0480, 0xc00042f0e0) /usr/lib/golang/src/runtime/panic.go:967 +0x161 gopkg.in/redis%2ev5_test.ExampleClient() /home/mgoodwin/rpmbuild/BUILD/redis-5.2.9/_build/src/gopkg.in/redis.v5/example_test.go:71 +0x3ea testing.runExample(0x565544b9c21c, 0xd, 0x565544d59018, 0x565544ba744d, 0x1f, 0x0, 0x0) /usr/lib/golang/src/testing/run_example.go:62 +0x202 testing.runExamples(0xc00026fee8, 0x5655450c8640, 0xe, 0xe, 0x101) /usr/lib/golang/src/testing/example.go:44 +0x1aa testing.(*M).Run(0xc0000a0080, 0x0) /usr/lib/golang/src/testing/testing.go:1163 +0x1ee main.main() _testmain.go:110 +0x137 exit status 2 FAIL gopkg.in/redis.v5 48.849s error: Bad exit status from /var/tmp/rpm-tmp.Agiuj0 (%check) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
