https://bugzilla.redhat.com/show_bug.cgi?id=1800994 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- You need to link to the raw copy of the spec and srpm so that fedora-review works. Lower-case is preferred, though not required. However, you should be consistent about it; this review should be for RaySession, not raysession, and the %global pname seems unused. https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity All the %globals at the top of the spec are unnecessary. You are building a tagged release, not a snapshot. BuildArch, not BuildArchitectures. I don't know why you have filtering for libjack, there is neither libjack.so listed in files, nor any compiled files that would cause there to be Requires on it. INSTALL.md is not a necessary %doc. COPYING should be marked as %license instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
