[Bug 1795204] Review Request: rust-rustyline-derive - Rustyline derive macros (Completer, Helper, Hinter, Highlighter)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1795204



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Jerry James from comment #2)
> While there is a %check script and it runs successfully, that's because
> there are 0 tests.  I don't know that having a %check script is useful when
> there are no tests.  You may want to remove it, but I won't insist.

Good catch. But I don't think it's harmful (since it's essentially a no-op in
this case), and I don't want to deviate from the rust package template too far.
Also, by leaving it in I don't have to add it back once upstream adds some test
cases.

> This package is APPROVED.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux