https://bugzilla.redhat.com/show_bug.cgi?id=1796711 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Jerry James from comment #2) > Thanks for the review! > > (In reply to Sandro Mani from comment #1) > > (Curiosity: [1] states that the pyproject macros work if the project > > includes pyproject.toml, but the sources contain no such file. So how is > > this actually working?) > > I'm afraid I don't know the answer to that question myself, although I'm > sure Miro does. It looks like the commands invoked by the pyproject macros > must parse setup.py, since they find the requests and Jinja2 dependencies. > Either that or they invoke black magic. Possibly both. Here I come, summoned by my name being spoken. The pyproject.toml file specifies a build backend. For easier adoption, we select "setuptools.build_meta" build backend when the pyproject.toml file is not present or it is oresent but the backend is not specified. The "setuptools.build_meta" build backend is backwards compatible with setup.py files. For curiosity, see get_backend() in https://src.fedoraproject.org/rpms/pyproject-rpm-macros/blob/master/f/pyproject_buildrequires.py#_125 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
