https://bugzilla.redhat.com/show_bug.cgi?id=1795249 --- Comment #3 from dan.cermak@xxxxxxxxxxxxxxxxxxx --- (In reply to Marek Blaha from comment #2) > Thanks for the review! > > Running the tests is tricky. The cmake directly downloads google tests > libraries using git from github.com which does not work when the builder > does not have access to the network (see the scratch build > https://koji.fedoraproject.org/koji/taskinfo?taskID=41238632). > > I tried to replace it using packaged version of the library (BuildRequires: > pkgconfig(gtest)), but this did not work neither due to using of some > features not available in released version yet. (e.g. GTEST_SKIP). Fair enough. You might want to try to persuade upstream to support a stable gtest not to download it from the internet at configuration time, but I'd leave this up to you. > > All other issues should be now fixed. Thank you, package approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
