[Bug 1794229] Review Request: rubygem-rspec-fire - More resilient test doubles for RSpec.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1794229

Alejandro Alvarez <a.alvarezayllon@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |a.alvarezayllon@xxxxxxxxx
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Alejandro Alvarez <a.alvarezayllon@xxxxxxxxx> ---
Hi,

It is better if you point to the raw spec file, not the gihub page, otherwise
fedora-review can not process it (I have done this in the past too!)

I have checked the spec file from the source rpm and the one you give and the
changelogs are different:

< * Wed Dec 18 2019 Breno Brand Fernandes <brandfbb@xxxxxxxxx> - 3.3.2-14
---
> * Wed Dec 18 2019 Breno Brand Fernandes <brandfbb@xxxxxxxxx> - 1.3.0-1


I guess a C&P error from some other rpm? Can you provide another source rpm
built with the right spec?

rpmlint:

rubygem-rspec-fire.noarch: W: summary-ended-with-dot C More resilient test
doubles for RSpec.
rubygem-rspec-fire.noarch: W: incoherent-version-in-changelog 3.3.2-14
['1.3.0-1.el8', '1.3.0-1']
rubygem-rspec-fire.src: W: summary-ended-with-dot C More resilient test doubles
for RSpec.
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Note the "incoherent-version-in-changelog"

fedora-review complains about "[!]: Test suite of the library should be run.",
but from what I can see this package does not seem to have tests.

You should drop the dependency on ruby:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Ruby/

* There SHOULD NOT be Requires: ruby(release), unless you want to explicitly
specify Ruby version compatibility. The automatically generated dependency on
RubyGems (Requires: ruby(rubygems)) is enough.


Similarly 

* There SHOULD NOT be any rubygem Requires nor Provides listed, since those are
autogenerated.


As it is now, the resulting rpms do not seem to be installable:

Error: 
 Problem 1: conflicting requests
  - nothing provides (rubygem(rspec) < 4 with rubygem(rspec) >= 2.11) needed by
rubygem-rspec-fire-1.3.0-1.el8.noarch
  - nothing provides rubygem-rspec >= 2.11 needed by
rubygem-rspec-fire-1.3.0-1.el8.noarch
  - nothing provides rubygem-rspec < 4 needed by
rubygem-rspec-fire-1.3.0-1.el8.noarch
 Problem 2: package rubygem-rspec-fire-doc-1.3.0-1.el8.noarch requires
rubygem-rspec-fire = 1.3.0-1.el8, but none of the providers can be installed
  - conflicting requests
  - nothing provides (rubygem(rspec) < 4 with rubygem(rspec) >= 2.11) needed by
rubygem-rspec-fire-1.3.0-1.el8.noarch
  - nothing provides rubygem-rspec >= 2.11 needed by
rubygem-rspec-fire-1.3.0-1.el8.noarch
  - nothing provides rubygem-rspec < 4 needed by
rubygem-rspec-fire-1.3.0-1.el8.noarch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux