Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adanaxisgpl - FPS game in 4 spatial dimensions https://bugzilla.redhat.com/show_bug.cgi?id=309061 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-10-12 10:52 EST ------- Well, I must say that there are some issues to fix on 1.2.1-1 spec/srpm. Please check the following URLs for general packaging procedure. http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/DistTag A. Description stage * Please explain why you want to introduce seemingly-redundant macros like %name, %version, ..... etc * Please consider to use %?dist tag. * Please follow the BuildRoot format requested for Fedora. * Remove redundant BuildRequires - For example, libGLU-devel requires libGL-devel, so "BuildRequires: libGL-devel" can be removed - Remove BuildRequires listed on "Exceptions" list on "Guidelines" wiki. - Also I suggest to write one BuildRequires per one line because * it makes easier to read * it makes easier to find out the difference when BuildRequiers changes. * Check the missing BuildRequires - This srpm cannot be rebuilt. http://koji.fedoraproject.org/koji/taskinfo?taskID=191544 At least libogg-devel is missing from BuildRequires. B. %prep/%build/%install stage * Support parallel make if possible, otherwise write as a comment which tells that this package cannot support parallel make. * Don't use %makeinstall unless it cannot be avoided. * Desktop files must be installed by "desktop-file-install" (BuildRequires: desktop-file-utils is needed). - I don't think the Category "X-MandrivaLinux-MoreApplications-Games-Arcade" is needed. - The category "MoreApplications" is not valid. ----------------------------------------------------------- error: value "Game;ActionGame;MoreApplications;X-MandrivaLinux-MoreApplications-Games-Arcade;" for key "Categories" in group "Desktop Entry" contains an unregistered value "MoreApplications" ----------------------------------------------------------- * When using "cp" or "install" command, add "-p" option to keep timestamps. * Consider to install pixmaps image data under %_datadir/icons/hicolor/??x??/apps and call gtk-update-icon-cache (please check the section "GTK+ icon cache" of http://fedoraproject.org/wiki/Packaging/ScriptletSnippets ) C. %files section * Make it sure that all directories created by this package are owned by this package. For example, %_datadir/adanaxisgpl/ itself is not owned by any package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review