Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: babl - A dynamic, any to any, pixel format conversion library https://bugzilla.redhat.com/show_bug.cgi?id=328771 ------- Additional Comments From pertusus@xxxxxxx 2007-10-12 10:34 EST ------- There is a dot missing at the end of the devel %description. Also the timestamps are still not kept. As above, I propose: make DESTDIR=%{buildroot} install INSTALL='install -p' The changelog entry is not very clear in my opinion: - Remove the use of inexistent source (from package reviews) I would suggest something along: - clarify how the source may be generated and don't mention the fact that the sources were inexistent, since the source were not really inexistent the url was. It is only a suggestion and not a big deal. As for shipping babl svn snapshot in F-7 I think that it should be avoided, unless there are severe regression/bugs or there are wonderful new functionalities. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review