https://bugzilla.redhat.com/show_bug.cgi?id=1795470 --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Wow, with all that language support, it's a pretty gnarly package ... :D Two questions: - Why not use the "standard method" of installing go "packages" (with the go macros)? - Did you consider requiring java-1.8.0-openjdk-aarch32 (don't depend on my spelling this correctly) on %ifarch %{arm}? It should speed up package builds significantly, and possibly also fix the test suite timeout issue. Here's an example of how it works: https://src.fedoraproject.org/rpms/jna/blob/master/f/jna.spec#_52 Otherwise: - License correct and permissible (3-Clause-BSD), and looks like the LICENSE.txt file is installed for every subpackage combination (please check). - Latest version is packaged. - BuildRequires look correct and are even sorted alphabetically :) - Patches are commented, but no reference to upstream issues or something like that (adding that would be great) - Package builds successfully when dependencies are present. - Built packages install successfully when dependencies are present. I'd just still like to see a successful koji scratch build (which means waiting for the dependencies to be imported into rawhide). Not because I don't trust local builds, but because we still need to check whether "noarch" subpackages are actually built identically on the different architectures. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
