https://bugzilla.redhat.com/show_bug.cgi?id=1795399 --- Comment #2 from Christian Kellner <ckellner@xxxxxxxxxx> --- Thanks a bunch, really appreciate it. (In reply to dan.cermak from comment #1) > - the license is wrong, the package is licensed under the GPLv3. Ups, sorry. > - there's no need to pass `-p1` to %autosetup, when no patches are added I don't see any harm doing it either but I have removed it. > - Is it necessary to pass `-Dversion=v%{version}` to meson? If I understand > the meson.build correctly, then it should use the correct value by itself. You are right, I was looking at latest version in hg where you need to pass it if it is not a checkout: https://hg.sr.ht/~scoopta/wofi/browse/default/meson.build > - Please pass a static url (preferably to the specific git commit) to the > *raw* spec file (i.e. no html), so that fedora-review can use the spec. Spec URL: https://raw.githubusercontent.com/gicmo/spec/a34e8409b8de7e1e710d5c6ad50a3ef3670cb84b/wofi/wofi.spec Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41217470 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
