https://bugzilla.redhat.com/show_bug.cgi?id=1795018 --- Comment #2 from Christian Kellner <ckellner@xxxxxxxxxx> --- Thanks a lot for the review! (In reply to dan.cermak from comment #1) > I have the following comments and suggestions: > 1. Add a link to the upstream pull request or commit from which you took the > patch. Done! > 2. consider adding a `Requires: systemd >= 243`, in case this spec gets > reused for older releases Great idea, done! > 3. you can save yourself the manual flag export by using the > `%set_build_flags` macro Cool, learn something new every day. > 4. please link directly to the spec file in raw form and preferably via a > stable URL (as mentioned in > https://bugzilla.redhat.com/show_bug.cgi?id=1795399#c1) Spec URL: https://raw.githubusercontent.com/gicmo/spec/63e0fdb4cf814de0a0f3d10c87ae8f96c58ed61a/brightnessctl/brightnessctl.spec Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41217160 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
