[Bug 1795461] Review Request: practrand - Software package for the Randon number generation & testing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1795461



--- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
As Artur pointed out, you need to add g++ to the BuildRequires. The build does
not currently succeed in mock because g++ is missing:

+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.sxPUlv
+ umask 022
+ cd /builddir/build/BUILD
+ cd practrand-0.95
+ g++ -c src/math.cpp src/non_uniform.cpp src/platform_specifics.cpp
src/rand.cpp src/sha2.cpp src/test_batteries.cpp src/tests.cpp
src/RNGs/arbee.cpp src/RNGs/chacha.cpp src/RNGs/efiix.cpp src/RNGs/hc256.cpp
src/RNGs/isaac.cpp src/RNGs/jsf.cpp src/RNGs/mt19937.cpp src/RNGs/rarns.cpp
src/RNGs/salsa.cpp src/RNGs/sfc.cpp src/RNGs/sha2_based_pool.cpp
src/RNGs/trivium.cpp src/RNGs/xsm.cpp src/RNGs/other/fibonacci.cpp
src/RNGs/other/indirection.cpp src/RNGs/other/mult.cpp
src/RNGs/other/simple.cpp src/RNGs/other/transform.cpp -I include -std=c++11
-O3 -g
/var/tmp/rpm-tmp.sxPUlv: line 33: g++: command not found
error: Bad exit status from /var/tmp/rpm-tmp.sxPUlv (%build)



Can you please correct the sourceurl also as Artur pointed out? Fedora-review
gives a warning already.

Could you also please test that your src rpm builds in mock (if it doesn't, it
won't build on koji either):
https://fedoraproject.org/wiki/Using_Mock_to_test_package_builds

I can continue with a full review once the build succeeds.

Cheers,

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux