[Bug 1794912] Review Request: nyancat - Nyancat rendered in your terminal.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1794912



--- Comment #10 from Artur Iwicki <fedora@xxxxxxxxxx> ---
>%build
>make %{?_smp_mflags} nyancat
You should call "%set_build_flags" before invoking make.

>install -m 0544 nyancat.1 %{buildroot}/%{_mandir}/man1/
0544 is read+execute,read,read - I think you wanted read+write,read,read = 0644
here.

>awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE
Personally, I'd move this to %prep.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux