Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pixel - CL web image gallery generator with JavaScript viewer Alias: px-review https://bugzilla.redhat.com/show_bug.cgi?id=261801 ------- Additional Comments From lkundrak@xxxxxxxxxx 2007-10-12 06:42 EST ------- Josef -- you still didn't fix some of what did I mention in comment #3, namely: (In reply to comment #3) > * Source: %{name}.tar.gz -- it would be great if the source code tarball name > contained the version. Even better if it you made it available for download > somewhere in Internet (people.redhat.com?) As far as I know you are the upstream of the package -- it shouldn't be hard for you to do the change. > * Prefix: %{_datadir}/px -- please note that making relocatable packages is > discouraged. See paragraph "Relocatable packages" in the Guidelines [1] Either clarify why do you need a relocatable package or remove this. > * The changelog time stamp lines should end with complete version-release pair, > e.g. 0-1, 0-2, 0-3 in your case. Each changelog entry should correspond to a > revision. Your package's version is 0, not 0.0. It would be great if you chose some sane versioning scheme and mentioned the version in the source tarball name. I see you changed the tarball without changing name -- please never do that. Apart from that I found another problem: 33 %files ... 38 %{prefix} Please don't do this -- enumerate just the files and directories your package creates and owns. You can even use wildcards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review