https://bugzilla.redhat.com/show_bug.cgi?id=1795461 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Summary: Software package for the Randon number generation & testing A typo here - "randon" instead of "random" ("m" replaced with "n"). >Group: Applications/System The Group: tag is not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >Source0: https://sourceforge.net/projects/pracrand/files/PractRand_%{version}.zip This URL does not exist - there's only "PractRand-pre0.95.zip". >BuildRequires: gcc, help2man, valgrind, dos2unix >[...] >g++ -c src/*.cpp src/RNGs/*.cpp src/RNGs/other/*.cpp -I include -std=c++11 -O3 -g /usr/bin/g++ is provided by the "gcc-c++" package, not "gcc". You should probably also call %set_build_flags at the start of %build so Fedora's CFLAGS and LDFLAGS are applied. Also, since you're calling g++ directly, it might be good to leave a comment saying that the upstream sources don't contain a Makefile (nor anything similar). >mkdir -p %{buildroot}%{_defaultdocdir}/%{name} >cp -p doc/* %{buildroot}%{_defaultdocdir}/%{name} Reading through the Packaging Guidelines, I think you should use %{_pkgdocdir} here instead of %{_defaultdocdir}. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
