https://bugzilla.redhat.com/show_bug.cgi?id=1794832 --- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> --- First pass through: > GOOS=windows %gocrossbuild -o ./fcct-windows internal/main.go Umm, is this 32-bit or 64-bit Windows? If it's for 64-bit Windows, it should probably be indicated as such. Technically, I have the same quibble with the Darwin build, but I think it's a lot less likely that would be confusing... :) > install -d -p %{buildroot}%{_libdir}/fcct Two things: 1. Why are we installing random binaries into %{_libdir}/fcct instead of %{_libexecdir}/fcct? 2. This directory is not correctly owned by any package generated by this spec. Please fix that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
