https://bugzilla.redhat.com/show_bug.cgi?id=1795071 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Doc Type|--- |If docs needed, set a value Flags| |fedora-review? --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I can review this package. Initial recommendations / suggestions: 1) You could replace the URL prefix in Source0 with %{url}. 2) Is there a reason why you're not using the sources from pypi? %{pypi_source} should work, unless the sdist doesn't contain test files (which is sometimes the case). 3) Missing \n before %prep? :) 4) Please use trailing slashes for directories in %files: %{python3_sitelib}/%{pypi_name}-%{version}-py*.egg-info/ Or use this, so you don't need the glob: %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/ Let me know when you're ready for the formal review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
