https://bugzilla.redhat.com/show_bug.cgi?id=1790241 --- Comment #14 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Sure, no problem. 1) You don't need to use a separate %{srcname} definition if you're only going to use it for %{name}. You can just drop the definition of srcname and use "Name: pipx" directly, and then replace usage of "%{srcname}" with the standard macro for "%{name}". 2) If the package has code licensed both under MIT and BSD licenses, then the License tag should be "MIT and BSD", not "MIT or BSD". The "or" case is only applicable for dual-licensed code. 3) %package %{srcname} is redundant, since it expands to %package pipx, which is already the main package. Just drop the separate %package line and Summary. 4) In that case, you also don't need to deduplicate the %description, since there's only one package. 5) %autosetup -n %{srcname}-%{version} is redundant, because the default value for the -n flag is "%{name}-%{version}". You can just use plain "%autosetup". 6) %files %{srcname} - again, this is redundant. Just use %files, since pipx is the "main" package anyway. That means the comment above %files can go too :) 7) The "standard" way to list python modules in %files would be like this, so you don't accidentally include too much (though your way should work as well): %{python3_sitelib}/%{pypi_name}/ %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/ Last question: Is the "pipx" python module only used internally, or is it expected to be imported by third-party packages? If the latter is the case, you might want to split it off into a separate "%package -n python3-%{name}" instead, and Require it from the main pipx package. If its only used internally, it's fine to include it in the main pipx package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
