https://bugzilla.redhat.com/show_bug.cgi?id=1778512 --- Comment #4 from james.p.elford@xxxxxxxxx --- Thanks for looking at this. Sorry to take such a long time coming back. Hopefully things are in a better state now - latest copr output here, which has the .spec file, along with the source and x84_64 RPMs: https://copr-be.cloud.fedoraproject.org/results/jelford/brightnessctl/fedora-31-x86_64/01185238-brightnessctl/ Builds for rawhide and aarch64 can be found here: https://copr.fedorainfracloud.org/coprs/jelford/brightnessctl/build/1185238/ One thing I wasn't sure about: > Changelog entry is not okay: I think this should be okay now, but I'm a little uncertain how these should be. I've bumped the "Release" version each time I've tweaked the .spec file - so that anyone consuming my copr repo would see a new version - but of course if this package is accepted, then from the "fedora" point of view this would be the "first" release (for upstream version 0.4). Would you be able to give me some guidance on this please? Hopefully the rest of the points are now addressed: > Man pages must not be marked as %doc: Fixed > Use a better name for your archive: Updated > DESTDIR=%{buildroot} is already included in %make_install Updated > Install the readme with %doc: Done > Use Fedora default build flags: Updated > Sunce the binary is suid you must set hardening flags: Thanks, updated. I hope this will go away shortly since the author has plans to move to a non-setuid mode (in version 0.5), but for now have just corrected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
