[Bug 1793156] Review Request: rr - Tool to record and replay execution of applications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1793156

Robert-André Mauchin <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #4 from Robert-André Mauchin <zebob.m@xxxxxxxxx> ---
 The file section is not good:

 - %defattr(-,root,root,-) is not needed

 - Be more specific here:

%{_libdir}/*

 - use %{_bindir} and %{_datadir}:

/usr/bin/rr
/usr/bin/rr_exec_stub*
/usr/bin/rr_page*
/usr/bin/signal-rr-recording.sh
/usr/bin/rr-collect-symbols.py
/usr/share/bash-completion/completions/rr
/usr/share/rr/*.xml

 - Why are you using a GIT snapshot instead of the latest release?

Version:        5.3.0

[…]

Source:
https://github.com/mozilla/rr/archive/%{version}/%{name}-%{version}.tar.gz

[…]

%setup -q -n rr-%{version}

 - Use python3_version_nodots:

BuildRequires: python%{python3_version_nodots}-pexpect

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux