https://bugzilla.redhat.com/show_bug.cgi?id=1790838 --- Comment #4 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to dan.cermak from comment #3) > I'll take a closer look during the weekend. > > A few suggestions: > - use %make_build and %make_install instead of manual make invocations > - %ldconfig_scriptlets is obsolete and can be removed done > - consider using %autosetup instead of %setup & %patch %autosetup doesn't allow patch backups, see https://rpm.org/user_doc/autosetup.html > - don't bump Release before the package is published That would go against long-standing, established policy in Fedora package review; how will anyone know what has changed? See https://fedoraproject.org/wiki/FrequentlyMadePackagingMistakes?rd=Packaging:FrequentlyMadeMistakes > - where does the existing %changelog come from? See comment 0. https://jussilehtola.fedorapeople.org/libcint.spec https://jussilehtola.fedorapeople.org/libcint-3.0.19-3.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
