[Bug 1778537] Review Request: consolation - Copy-paste for the Linux console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1778537



--- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> ---
Thank you. Updated package below.

(In reply to Robert-André Mauchin from comment #1)
>  - make DESTDIR=%{buildroot} install  %make_install

Okay

>  - You need to run the scriptlets in the correct sections:
> 
> %post
> %systemd_post consolation.service
> 
> %preun
> %systemd_preun consolation.service
> 
> %postun
> %systemd_postun consolation.service
> 
>  Right now you are running them in install which is not what you want.

Whoopsie, how embarassing. Fixed.

>  - Don't mix tabs and spaces:
> 
> consolation.src:16: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab:
> line 1)

Fixed.

SPEC: https://people.freedesktop.org/~lkundrak/SPECS/consolation.spec
SRPM:
https://people.freedesktop.org/~lkundrak/SRPMS/consolation-0.0.7-1.fc31.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux