https://bugzilla.redhat.com/show_bug.cgi?id=1792224 --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- (In reply to dan.cermak from comment #2) > I have the following suggestions for the spec: > - use %autosetup -n %{gh_project}-%{version}%{?prever:-dev} -p1 instead of > %setup and %patch > - use %make_build and %make_install instead of the manual make invocations I prefer to keep using the "old" way, which stays compatible with older distros and older build systems (without epel-rpm-macros) > - upstream has support for doxygen docs, have you considered building these > too? No (I think that nowaday, everybody use online documentation) but it can be added later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx