Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtune - standard API to access the kernel tunables https://bugzilla.redhat.com/show_bug.cgi?id=210007 ------- Additional Comments From nadia.derbey@xxxxxxxx 2007-10-11 05:21 EST ------- The way the package builds currently is that it takes the kernel release and distro release from what is installed on the machine we are building on: 1) kernel release comes from the kernel-headers installed package version and is passed to the make command as the KVERSION to build against. I think this part is OK since we have the right info in the mock environment. 2) distro release is computed in the Makefile (if not passed to the Makefile) and is the result of an "lsb_release -r". I think the problem comes from this 2nd part: we should also provide the distro release to the make command in the spec file. Now, can you please confirm what I say after: the %{?dist} tag is THE way we have to know what distro release target we are building for. Or is there a more secure way to know the target we are building for? As soon as I get your answer, I'll send you the fix: it should only be a small change in the spec file. Thanks, Nadia -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review