https://bugzilla.redhat.com/show_bug.cgi?id=1788594 --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License is ok Description is ok URL does not work. FIX: Please replace it with https://metacpan.org/release/Time-Fake Source0 should not use www.cpan.org FIX: Please replace Source0 with https://cpan.metacpan.org/modules/by-module/Time/Time-Fake-%{version}.tar.gz All tests passed BuildRequires FIX: Please add build-requires: - perl(strict) - lib/Time/Fake.pm:3 - perl(vars) - lib/Time/Fake.pm:4 TODO: The easier way to remove .packlist is used NO_PACKLIST=1 option, which is part of perl(ExtUtils::MakeMaker) >= 6.76. Add the option to 'perl Makefile.PL' TODO: In spec file, please consider replacing 1) perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" by perl Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS" NO_PACKLIST=1 NO_PERLLOCAL=1 2) make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; by %make_install TODO: If you don't want to use previous changes, then please - replace PERL_INSTALL_ROOT with more common DESTDIR. - remove deleting empty directories, because it is not needed. - add build-requires 'make', 'coreutils', 'findutils' $ rpm -qp --requires perl-Time-Fake-0.11-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Carp) 1 perl(:MODULE_COMPAT_5.30.1) 1 perl(strict) 1 perl(vars) Binary requires are Ok. $ rpm -qp --provides perl-Time-Fake-0.11-1.fc32.noarch.rpm | sort | uniq -c 1 perl(Time::Fake) = 0.11 1 perl-Time-Fake = 0.11-1.fc32 Binary provides are Ok. $ rpmlint ./perl-Time-Fake* perl-Time-Fake.noarch: W: spelling-error %description -l en_US localtime -> local time, local-time, mealtime perl-Time-Fake.noarch: W: spelling-error %description -l en_US gmtime -> gm time, gm-time, time perl-Time-Fake.noarch: W: invalid-url URL: https://metacpan.org/pod/Time-Fake/ HTTP Error 404: Not Found perl-Time-Fake.src: W: spelling-error %description -l en_US localtime -> local time, local-time, mealtime perl-Time-Fake.src: W: spelling-error %description -l en_US gmtime -> gm time, gm-time, time perl-Time-Fake.src: W: invalid-url URL: https://metacpan.org/pod/Time-Fake/ HTTP Error 404: Not Found 2 packages and 1 specfiles checked; 0 errors, 6 warnings. URL has to be fixed. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Resolution: Not approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
