Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-nfs https://bugzilla.redhat.com/show_bug.cgi?id=226465 ------- Additional Comments From nphilipp@xxxxxxxxxx 2007-10-11 04:50 EST ------- (In reply to comment #1) > Preliminary Review:- > > rpmlint on SRPM and RPM gave me > ------------------------------------- > system-config-nfs.src:18: W: unversioned-explicit-obsoletes redhat-config-nfs added version > system-config-nfs.src: W: invalid-license GPL checked and changed to GPLv2+ > system-config-nfs.noarch: E: script-without-shebang > /usr/share/system-config-nfs/propertiesWindow.py > system-config-nfs.noarch: E: script-without-shebang > /usr/share/system-config-nfs/system-config-nfs.glade > system-config-nfs.noarch: E: script-without-shebang > /usr/share/system-config-nfs/nfsServer.py > system-config-nfs.noarch: E: script-without-shebang > /usr/share/system-config-nfs/nfsExports.py > system-config-nfs.noarch: E: script-without-shebang > /usr/share/system-config-nfs/nfsServerSettings.py > system-config-nfs.noarch: E: script-without-shebang > /usr/share/system-config-nfs/mainWindow.py made files be installed without executable bits set unless necessary > system-config-nfs.noarch: W: incoherent-version-in-changelog 1.3.27 1.3.27-1.fc8 added (non-dist-tagged) releases to changelog entries > system-config-nfs.noarch: W: invalid-license GPL > system-config-nfs.noarch: W: obsolete-not-provided redhat-config-nfs idem > system-config-nfs.noarch: W: conffile-without-noreplace-flag > /etc/pam.d/system-config-nfs > system-config-nfs.noarch: W: conffile-without-noreplace-flag > /etc/security/console.apps/system-config-nfs aded %config(noreplace) > -------------------------------------------------- > > also, > good to use %defattr(-,root,root,-) changed > Update package. Better to provide new SPEC and SRPM links for this package > before actually committing in CVS. Package is building right now (this is a merge review). (In reply to comment #2) > Using xdg-open would be better than htmlview: > > http://www.redhat.com/archives/fedora-devel-list/2007-October/msg00025.html > http://scop.fedorapeople.org/patches/xdg-utils/system-config-nfs.patch xdg-open and htmlview are tried in this order, changed requirements suitably for Fedora >= 7. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review